ci: bump deprecated actions/checkout v2/v3 to v4 - #3952
Conversation
v2 runs on the removed Node 12 runtime and v3 on the deprecated Node 16 runtime. Align them with the v4 already used by 21 other workflows. Signed-off-by: boleklebovski <160799963+boleklebovski@users.noreply.github.com>
|
@boleklebovski is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
| working-directory: target_chains/fuel/contracts/ | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🔍 Checkout step carries an input that belongs to the Rust toolchain action
This step passes cache-workspaces to actions/checkout, which is not a valid input for that action (it belongs to actions-rust-lang/setup-rust-toolchain, which this workflow does not even use). GitHub only emits an "Unexpected input(s)" warning rather than failing, so bumping v2 -> v4 does not change behavior, but the caching that was presumably intended never happens. The same misplaced input exists at .github/workflows/ci-solana-contract.yml:33-34, where a real setup-rust-toolchain step follows on line 35 without the option. Worth cleaning up while touching these files.
Was this helpful? React with 👍 or 👎 to provide feedback.
Problem
.github/workflows/currently spans fouractions/checkoutmajors:actions/checkout@v2runs on the Node 12 runtime, which GitHub has removed, and@v3on the deprecated Node 16 runtime. Both emit deprecation annotations on every run today.Fix
Bump the 26 workflows still on v2 or v3 to
@v4. Nothing else changes — no job names, triggers, inputs or steps are touched, and every edit is the version string alone.On the target version
I aligned on v4 because it is the version most of this repo already uses (21 workflows). The repo also has 5 workflows on v5 and one SHA pin, so if you would rather standardise everything on v5 — or on a pinned SHA — say the word and I will retarget this branch; it is a mechanical find-and-replace either way.
I deliberately left the SHA-pinned workflow alone, since that pin looks intentional.
Verification
All 53 workflow files re-parsed as YAML after the change.
grepconfirms nocheckout@v2or@v3reference remains; the only versions left are v4, v5 and the intentional SHA pin.