Skip to content

set loop to None in Python 3.10 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2022
+3 −3
Merged

set loop to None in Python 3.10 #348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6223b9f
set loop to None in Python 3.10
basnijholt May 31, 2022
f4880d0
do not pass loop at all in Python 3.10
basnijholt May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions adaptive/runner.py
View file
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@
import itertools
import pickle
import platform
import sys
import time
import traceback
import warnings
@@ -640,9 +641,8 @@ async def _run(self):
try:
while not self.goal(self.learner):
futures = self._get_futures()
done, _ = await asyncio.wait(
futures, return_when=first_completed, loop=self.ioloop
)
kw = {"loop": self.ioloop} if sys.version_info[:2] < (3, 10) else {}
done, _ = await asyncio.wait(futures, return_when=first_completed, **kw)
self._process_futures(done)
finally:
remaining = self._remove_unfinished()