Fix positional arguments to request class methods - #171
Merged
Merged
Conversation
RazerM
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 96.33% 96.35% +0.01%
==========================================
Files 7 7
Lines 1147 1151 +4
Branches 129 129
==========================================
+ Hits 1105 1109 +4
Misses 25 25
Partials 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RazerM
force-pushed
the
feature/positional-class
branch
from
August 22, 2026 21:27
4b4f453 to
c708ec7
Compare
The forged methods bound class_ as a keyword in functools.partial, so
the documented equivalence st.gp_history(*args, **kw) ->
st.generic_request('gp_history', *args, **kw) raised TypeError for any
positional argument, which landed in the class_ slot.
RazerM
force-pushed
the
feature/positional-class
branch
from
August 23, 2026 13:09
c708ec7 to
1610a6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forged methods bound class_ as a keyword in functools.partial, so
the documented equivalence st.gp_history(*args, **kw) ->
st.generic_request('gp_history', *args, **kw) raised TypeError for any
positional argument, which landed in the class_ slot.