Make attrs.converters.pipe only return a Converter instance if one is passed #1380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
pipe()return a regular callable if only passed callables, only return aConverterinstance if one is strictly required (by having aConverterinstance within the pipeline.)Some tests are affected by this change (mostly in how
__annotations__is accessed), this PR reverts most of them to their state before #1267.Pull Request Check List
mainbranch – use a separate branch!Our CI fails if coverage is not 100%.
.pyi)..rstand.mdfiles is written using semantic newlines.changelog.d.