Conversation
Add news fragment
Tinche
approved these changes
Dec 14, 2024
Member
Tinche
left a comment
Tinche
left a comment
There was a problem hiding this comment.
LGTM.
We could probably make this faster by generating a specialized version of __replace__ and making evolve use it, but that would slow down class creation even further, so I'm not convinced it's worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1313
Had to move evolve over due to import cycles and fortunately RTD already supports 3.13.
Since it doesn't overwrite anything, I would wait with adding an own option for if someone actually misses it. 🤷♂️