Fix optional validator to accept tuples of len > 1#1496
Open
finite-state-machine wants to merge 10 commits intopython-attrs:mainfrom
Open
Fix optional validator to accept tuples of len > 1#1496finite-state-machine wants to merge 10 commits intopython-attrs:mainfrom
optional validator to accept tuples of len > 1#1496finite-state-machine wants to merge 10 commits intopython-attrs:mainfrom
Conversation
Contributor
Author
|
The "ty" type checker seems to be doing a poor job of inferring the type of the https://github.com/python-attrs/attrs/actions/runs/20684969634/job/59384179969?pr=1496 What would you suggest, @Tinche? |
Contributor
Author
Member
|
If the type hints are correct, there should be no workarounds to appease ty, but a Would it be possible to create a minimal reproducer for https://play.ty.dev/ so we could report it to them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT
The pre-commit hooks are reverting my work-around for the "ty" issue, even with an attempted work around for the pre-commit issue. Rather than adding yet another work-around, I'm going to see what the maintainers suggest.
Summary
Replaces #1495 (I renamed my branch, which closed the draft PR.)
The
optionalvalidator (attrs.validators.optional) should accept anytupleof validators, just as it accepts anylistof validators. It looks like the peculiar type annotation syntax for variable-lengthtuples (tuple[<type>, ...]) was overlooked, and the exactly-one-element form (tuple[<type>]) was inadvertently used instead.The proposed change corrects the annotation.
Pull Request Check List
mainbranch – use a separate branch!Our CI fails if coverage is not 100%.
.pyi).typing-examples/baseline.pyor, if necessary,typing-examples/mypy.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()and@attrs.define()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives.The next version is the second number in the current release + 1.
The first number represents the current year.
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
If the next version is the first in the new year, it'll be 23.1.0.
attrs.define()andattr.s(), you have to add version directives to both..rstand.mdfiles is written using semantic newlines.changelog.d.