-
Notifications
You must be signed in to change notification settings - Fork 68
Add feature: call with freshness threshold #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Daniel-Chin
wants to merge
7
commits into
python-cachier:master
Choose a base branch
from
Daniel-Chin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
afb3390
add caller_with_freshness_threshold
Daniel-Chin e402614
fix type
Daniel-Chin 418f052
simple test passed
Daniel-Chin e2aca2d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c6fbdcd
Apply suggestions from code review
Borda 3523c65
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dce40a9
Merge branch 'master' into master
Borda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import time | ||
from datetime import timedelta | ||
|
||
import cachier | ||
|
||
|
||
def test_call_with_freshness_threshold(): | ||
@cachier.cachier() | ||
def test_func(a, b): | ||
print("Computing...") | ||
return a + b | ||
|
||
print(f"{test_func(1, 2) = }") | ||
print(f"{test_func(1, 2) = }") | ||
caller_with_freshness_threshold = ( | ||
test_func.caller_with_freshness_threshold( | ||
timedelta(seconds=0.5), | ||
) | ||
) | ||
print(f"{caller_with_freshness_threshold(1, 2) = }") | ||
print(f"{time.sleep(1.0) = }") | ||
print(f"{test_func(1, 2) = }") | ||
print(f"{caller_with_freshness_threshold(1, 2) = }") | ||
Comment on lines
+13
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are all the prints needed, why just not assert for expected outcomes? |
||
|
||
|
||
if __name__ == "__main__": | ||
test_call_with_freshness_threshold() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.