-
Notifications
You must be signed in to change notification settings - Fork 51
Allow to validate yaml file against its modeline schema #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nikaro
wants to merge
1
commit into
python-jsonschema:main
Choose a base branch
from
nikaro:feat/yaml-modeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,18 @@ | ||
from .errors import SchemaParseError, UnsupportedUrlScheme | ||
from .main import BuiltinSchemaLoader, MetaSchemaLoader, SchemaLoader, SchemaLoaderBase | ||
from .main import ( | ||
BuiltinSchemaLoader, | ||
MetaSchemaLoader, | ||
ModelineSchemaLoader, | ||
SchemaLoader, | ||
SchemaLoaderBase, | ||
) | ||
|
||
__all__ = ( | ||
"SchemaParseError", | ||
"UnsupportedUrlScheme", | ||
"BuiltinSchemaLoader", | ||
"MetaSchemaLoader", | ||
"ModelineSchemaLoader", | ||
"SchemaLoader", | ||
"SchemaLoaderBase", | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
|
||
import functools | ||
import pathlib | ||
import re | ||
import typing as t | ||
import urllib.error | ||
import urllib.parse | ||
|
@@ -233,6 +234,26 @@ def _dialect_of_schema(schema: dict[str, t.Any] | bool) -> str | None: | |
return schema_dialect | ||
|
||
|
||
class ModelineSchemaLoader(SchemaLoader): | ||
def __init__(self, *, instancefiles: tuple[t.IO[bytes], ...] | None = None) -> None: | ||
if not instancefiles: | ||
instancefiles = () | ||
if len(instancefiles) > 1: | ||
raise NotImplementedError( | ||
"'--modeline-schema' cannot be used on multiple files simultaneously." | ||
) | ||
self.schemafile = self._get_schema_from_modeline(instancefiles[0]) | ||
super().__init__(self.schemafile) | ||
|
||
def _get_schema_from_modeline(self, instancefile: t.IO[bytes]) -> str: | ||
modeline = instancefile.readline() | ||
pattern = r"^# yaml-language-server: \$schema=(?P<schema>.*)$" | ||
match = re.match(pattern, modeline.decode()) | ||
if not match: | ||
raise Exception("Modeline with schema not found.") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe there is something better than raising a bare |
||
return match.group("schema") | ||
|
||
|
||
class BuiltinSchemaLoader(SchemaLoader): | ||
def __init__(self, schema_name: str, *, base_uri: str | None = None) -> None: | ||
self.schema_name = schema_name | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
--yaml-modeline-schema
? Since this is very specific to YAML for now... or maybe going with this and raising aNotImplementedError
on other content than yaml?