Skip to content

Fix pendulum.tz.timezones() to use system tzdata #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2025
Merged

Fix pendulum.tz.timezones() to use system tzdata #801

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe0b356
Fix `pendulum.tz.timezones()` to use system tzdata
mgorny Feb 2, 2024
077d69e
Fix type hints
mgorny Mar 31, 2025
de3b199
Remove unused `_timezones` variable
mgorny Mar 31, 2025
e533943
Remove unused imports
mgorny Mar 31, 2025
02890eb
Add caching to `timezones()`
mgorny Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions src/pendulum/tz/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
from __future__ import annotations

from importlib import resources
from typing import TYPE_CHECKING
from typing import cast
from functools import cache
from zoneinfo import available_timezones

from pendulum.tz.local_timezone import get_local_timezone
from pendulum.tz.local_timezone import set_local_timezone
Expand All @@ -12,27 +11,16 @@
from pendulum.tz.timezone import Timezone


if TYPE_CHECKING:
from pathlib import Path


PRE_TRANSITION = "pre"
POST_TRANSITION = "post"
TRANSITION_ERROR = "error"

_timezones = None

_tz_cache: dict[int, FixedTimezone] = {}


def timezones() -> tuple[str, ...]:
global _timezones

if _timezones is None:
with cast("Path", resources.files("tzdata").joinpath("zones")).open() as f:
_timezones = tuple(tz.strip() for tz in f.readlines())

return _timezones
@cache
def timezones() -> set[str]:
return available_timezones()


def fixed_timezone(offset: int) -> FixedTimezone:
Expand Down