Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded time units with named constants #867

Merged
merged 4 commits into from
Mar 30, 2025

Conversation

Minku-Koo
Copy link
Contributor

  • Replaced hardcoded time-related values with named constants.
  • Facilitates easier adjustments of these values and reduces potential for errors.

Re-upload Pull Request #861

- Replaced hardcoded time-related values with named constants.
- Facilitates easier adjustments of these values and reduces potential for errors.
- Ensures better adherence to PEP 8 naming conventions and improves code readability.
Copy link

codspeed-hq bot commented Mar 30, 2025

CodSpeed Performance Report

Merging #867 will not alter performance

Comparing Minku-Koo:koo-macro (7a86096) with master (4d7e42a)

Summary

✅ 1 untouched benchmarks

@Secrus Secrus merged commit a5efba4 into python-pendulum:master Mar 30, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants