Add a final line-ending if multi-line input string #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this final line-ending, reordering steps will fail because tables will be added directly to the previous value (see issue python-poetry#381) when creating the string from the Container again, we remove any final line-ending if we added it initially to ensure we do not modify the original behavior
|
Checked the two unit tests that are failing, one is doing a parse, copy, as_string of Would this not need to actually have the trailing newline? The other unit tests that now fails is parsing the value: Not sure how I would need to fix this. An alternative to my current approach of adding a final new-line to the input string would be to fix this when reordering the items in an array instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this final line-ending, reordering steps will fail because tables will be added directly to the previous value (see issue #381)
when creating the string from the Container again, we remove any final line-ending if we added it initially to ensure we do not modify the original behavior
This modification only fails on two unit tests. However, I do not know enough about the TOML specifiation to see why this is a problem. Is there anybody that could help out and point me to a direction on how I can fix these final two unit tests?