Revert LinkedIn OAuth2 #1147
Merged
Revert LinkedIn OAuth2 #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
+ Coverage 77.87% 77.88% +0.01%
==========================================
Files 353 353
Lines 10794 10799 +5
Branches 471 471
==========================================
+ Hits 8406 8411 +5
Misses 2222 2222
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Merged, thanks for your contribution! |
|
Hello, is it possible to create hotfix release with this fix? LinkedinOAuth2 does not work for our service and we have to copy-paste whole LinkedinOAuth2 from previous version as it critical to our users to be able to login into their accounts |
|
I wanted to merge #1183 before the release, but it is not yet ready... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #950 mistakenly replaced the OAuth2 endpoint with the OpenID Connect one. Users who use OpenID Connect should use
LinkedinOpenIdConnect. For existing LinkedIn OAuth2 users like myself,LinkedinOAuth2should still work.Just to clarify: LinkedIn has NOT removed the
r_liteprofilescope for OAuth2 users — it's still functioning properly. If anyone is having issues with scopes, please check the “Products” tab in your LinkedIn App Setup page.For example, here we have both OAuth2 and OpenID Connect enabled:
