This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Add API for SessionStore #159
Closed
+217
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
commented
Nov 27, 2019
| comparing the host to a preloaded list of domains or if the | ||
| 'Strict-Transport-Security' header was sent on a previous response. | ||
| """ | ||
| async def get_tls_session_tickets( |
There was a problem hiding this comment.
Should change this to singular to match the interface.
sethmlarson
changed the title
|
I started to comment on this, then realized my comment was not really specific to any of the code in this PR, so I posted it here instead: #141 (comment) |
|
Closing these API PRs in favor of a scratch branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the SessionStore interface which I believe should be covered by
unasyncso we can have both an asynchronous SessionStore for async sessions and sync for sync sessions. If anyone thinks this can be handled without having two flavors that'd be great. :)Originally I had a more funneled
get()andset()scheme but the parameter and return types were completely different for every case so I went the route of having separate functions, would like some feedback on that.The way I'm imagining SessionStore's being created in-general is via strings /
pathlib.Pathobjects similar to howsqlite3.connect()can take":memory:"and you get an in-memory SQLite database. That way users don't have to make sure they're passing the correctly-flavored session store to their session, they automatically either get the sync or async variety. :)