Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation build #363

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix documentation build #363

merged 1 commit into from
Oct 18, 2021

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Oct 4, 2021

It took me a lot of time to understand that even with our version pins we were using PyOpenSSL's latest intersphinx mapping, and that it was incorrect: pyca/pyopenssl#1046.

@pquentin pquentin requested a review from njsmith October 4, 2021 07:11
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #363 (c32b35d) into master (d4126fd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1169      1169           
  Branches        46        46           
=========================================
  Hits          1169      1169           

@njsmith
Copy link
Member

njsmith commented Oct 4, 2021

Oh shoot, that's tricky.

I'm worried about hard-coding a specific version in conf.py... it will inevitably get stale if we don't have some mechanism for updating it.

I'm actually talking to @reaperhulk about the next pyopenssl release right now, for the DTLS stuff -- maybe we can just fix this upstream?

Copy link

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (sorry didn't see this already had a review on it)

@njsmith
Copy link
Member

njsmith commented Oct 5, 2021

This is fixed in pyopenssl main branch now, so I guess our options are:

  • merge and then revert as soon as pyopenssl releases
  • switch to linking to the latest docs instead of stable
  • do nothing and wait for pyopenssl to release, at which point this will fix itself

Next pyopenssl release will be right after pyca/pyopenssl#1026 is merged, and I'm nagging them to review it now, so hopefully soon.

@pquentin
Copy link
Member Author

pquentin commented Oct 5, 2021

I like doing nothing, so let's wait a bit more. 👍

Thanks for the help and detailed post about our options!

@pquentin pquentin merged commit d714a4a into python-trio:master Oct 18, 2021
@pquentin pquentin deleted the fix-build branch October 18, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants