-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-74598: add fnmatch.filterfalse
for excluding names
#121185
Open
picnixz
wants to merge
14
commits into
python:main
Choose a base branch
from
picnixz:fnmatch-filterfalse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnmatch.filterfalse
for excluding patternsfnmatch.filterfalse
for excluding names
dg-pb
reviewed
Jun 30, 2024
dg-pb
reviewed
Jun 30, 2024
FT failure is known so I'll wait until the fix (#130724) is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting review
stale
Stale PR or inactive for long period of time.
stdlib
Python modules in the Lib dir
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this implementation, I did not use a lambda function as it was proposed in the original patch nor did I use auxiliary functions. The reason is:
Therefore, I think it's better not to use a lambda function. I have a small question but would it make sense to re-implement fnmatch in C? (this may be a question for @barneygale)
Additional benchmarks
The benchmark script is:
📚 Documentation preview 📚: https://cpython-previews--121185.org.readthedocs.build/