Skip to content

gh-127146: Resolve some minor problems in Emscripten tests #127565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

gh-127146: Resolve some minor problems in Emscripten tests #127565

merged 1 commit into from
Dec 4, 2024

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Dec 3, 2024 •
edited by bedevere-app bot
Loading

  • Emscripten has_strftime_extensions
  • fma doesn't handle negative zero correctly in Emscripten
  • Emscripten has similar limited stack depth to wasi and apple in test_marshall

@hoodmane
pythongh-127146: Skip some minor problems in Emscripten tests
4bfeb60 
* Emscripten has_strftime_extensions
* fma doesn't handle negative zero correctly in Emscripten
* Emscripten has similar limited stack depth to wasi and apple in test_marshall
@hoodmane hoodmane requested a review from freakboy3742 December 3, 2024 14:34
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Dec 3, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 3, 2024
Open
@hoodmane hoodmane changed the title gh-127146: Skip some minor problems in Emscripten tests gh-127146: Resolve some minor problems in Emscripten tests Dec 3, 2024
freakboy3742
freakboy3742 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 These all make sense; thanks for the PR.

@freakboy3742 freakboy3742 merged commit 0f91078 into python:main Dec 4, 2024
48 checks passed
@hoodmane hoodmane deleted the fix-minor-emscripten-tests branch December 4, 2024 10:16
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@hoodmane @srinivasreddy
pythongh-127146: Resolve some minor problems in Emscripten tests (pyt…
4fe70db 
…hon#127565)

Adjusts some Emscripten test exclusions regarding strftime, fma, and stack depth.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
OS-emscripten skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @freakboy3742