Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-128772: Fix pydoc for methods with __module__ is None #129177

Merged
merged 1 commit into from
Feb 4, 2025
Merged

gh-128772: Fix pydoc for methods with __module__ is None #129177

merged 1 commit into from
Feb 4, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 22, 2025 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 22, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 22, 2025
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 22, 2025
Closed
Viicos
Viicos approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for me this looks good. As I mentioned here, do you think there's value in special casing deprecated classes in pydoc when using the decorator?

@serhiy-storchaka serhiy-storchaka merged commit 979d766 into python:main Feb 4, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2025
@serhiy-storchaka @miss-islington
pythongh-128772: Fix pydoc for methods with __module__ is None (pytho…
6625b13 
…nGH-129177)

(cherry picked from commit 979d766)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2025

GH-129653 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 4, 2025
@miss-islington-app
Copy link

Sorry @serhiy-storchaka, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.13" label.
Please backport backport using cherry_picker on the command line.

cherry_picker 979d76620990e6f8d68fa63e0ae0db1ec5b4d14c 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2025
@serhiy-storchaka @miss-islington
pythongh-128772: Fix pydoc for methods with __module__ is None (pytho…
bda0d99 
…nGH-129177)

(cherry picked from commit 979d766)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2025

GH-129654 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 4, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label Feb 4, 2025
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2025
@serhiy-storchaka @miss-islington
pythongh-128772: Fix pydoc for methods with __module__ is None (pytho…
d5a9a57 
…nGH-129177)

(cherry picked from commit 979d766)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka deleted the pydoc-module-none branch February 4, 2025 14:28
@miss-islington-app
Copy link

Sorry @serhiy-storchaka, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.13" label.
Please backport backport using cherry_picker on the command line.

cherry_picker 979d76620990e6f8d68fa63e0ae0db1ec5b4d14c 3.13

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 4, 2025
@serhiy-storchaka
[3.13] pythongh-128772: Fix pydoc for methods with __module__ is None (…
a294f9c 
…pythonGH-129177)

(cherry picked from commit 979d766)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 4, 2025

GH-129655 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 4, 2025
serhiy-storchaka added a commit that referenced this pull request Feb 4, 2025
@miss-islington @serhiy-storchaka
[3.12] gh-128772: Fix pydoc for methods with __module__ is None (GH-1…
0d207c3 
…29177) (GH-129654)

(cherry picked from commit 979d766)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Feb 5, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-128772: Fix pydoc for methods with __module__ is None (GH-1…
7eba097 
…29177) (GH-129653)

(cherry picked from commit 979d766)

Co-authored-by: Serhiy Storchaka <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@serhiy-storchaka @srinivasreddy
pythongh-128772: Fix pydoc for methods with __module__ is None (pytho…
3680b80 
…nGH-129177)
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@serhiy-storchaka @cmaloney
pythongh-128772: Fix pydoc for methods with __module__ is None (pytho…
1bb2b62 
…nGH-129177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos approved these changes

Assignees

@serhiy-storchaka serhiy-storchaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @Viicos