Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117657: Enable test_opcache under TSAN #129831

Merged
merged 1 commit into from
Feb 11, 2025
Merged

gh-117657: Enable test_opcache under TSAN #129831

merged 1 commit into from
Feb 11, 2025

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Feb 7, 2025 •
edited
Loading

Fix a few thread-safety bugs to enable test_opcache when run with TSAN:

@colesbury
pythongh-117657: Enable test_opcache under TSAN
a6c8937 
Fix a few thread-safety bugs to enable test_opcache when run with TSAN:

 * Use relaxed atomics when clearing `ht->_spec_cache.getitem`
   (pythongh-115999)
 * Add temporary suppression for type slot modifications (pythongh-127266)
 * Use atomic load when reading `*dictptr`
@bedevere-app bedevere-app bot mentioned this pull request Feb 7, 2025
Open
@colesbury colesbury marked this pull request as ready for review February 7, 2025 22:08
@colesbury colesbury requested a review from mpage February 7, 2025 22:08
@colesbury colesbury merged commit f151d27 into python:main Feb 11, 2025
59 checks passed
@colesbury colesbury deleted the gh-117657-opcache branch February 11, 2025 21:53
@ZeroIntensity ZeroIntensity mentioned this pull request Feb 26, 2025
Closed
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Feb 26, 2025
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f151d271591ec525eaf01fa7b128e575374888b9 3.13

colesbury added a commit to colesbury/cpython that referenced this pull request Feb 26, 2025
@colesbury
[3.13] pythongh-117657: Enable test_opcache under TSAN (pythonGH-129831)
7797bf5 
Fix a few thread-safety bugs to enable test_opcache when run with TSAN:

 * Use relaxed atomics when clearing `ht->_spec_cache.getitem`
   (pythongh-115999)
 * Add temporary suppression for type slot modifications (pythongh-127266)
 * Use atomic load when reading `*dictptr`
(cherry picked from commit f151d27)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2025

GH-130597 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 26, 2025
colesbury added a commit that referenced this pull request Feb 26, 2025
@colesbury
[3.13] gh-117657: Enable test_opcache under TSAN (GH-129831) (GH-130597)
9966dae 
Fix a few thread-safety bugs to enable test_opcache when run with TSAN:

 * Use relaxed atomics when clearing `ht->_spec_cache.getitem`
   (gh-115999)
 * Add temporary suppression for type slot modifications (gh-127266)
 * Use atomic load when reading `*dictptr`

(cherry picked from commit f151d27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpage mpage mpage approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@colesbury colesbury

Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @mpage