Skip to content

gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SET #132564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 27, 2025

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Apr 15, 2025

This PR is under developing, not ready for review

@Zheaoli
Copy link
Contributor Author

Zheaoli commented Apr 16, 2025

@brandtbucher Hi Brandt, I might need some help here.

I have already optimization path for _BUILD_STRING(I think we just need setup the const after we check all the opargs string on stack.

But I got a little bit confused for _BUILD_STRING. If I'm correct, _BUILD_SLICE is equal with BUILD_SLISE, I'm not sure it's necessary add an optimization path for _BUILD_SLICE. The result is const or not is not related with the argument?(not sure about this)

@brandtbucher
Copy link
Member

Hi @Zheaoli! Let's start by just setting the output types for these. I think maybe the constant output stuff may not be needed after all, due to GH-132733.

Zheaoli added 2 commits April 26, 2025 18:42
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli Zheaoli changed the title gh-131798: Add JIT path for _BUILD_STRING gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SLICE Apr 26, 2025
@Zheaoli Zheaoli changed the title gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SLICE gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SET Apr 26, 2025
Zheaoli added 3 commits April 26, 2025 19:51
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli Zheaoli marked this pull request as ready for review April 26, 2025 12:10
@Zheaoli Zheaoli requested a review from Fidget-Spinner as a code owner April 26, 2025 12:10
@Fidget-Spinner Fidget-Spinner merged commit 614d792 into python:main Apr 27, 2025
58 checks passed
@Zheaoli Zheaoli deleted the manjusaka/build-string branch April 27, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants