-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-63882: Use self.assert*
in test_minidom
#133000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there are assertTrue(not ...)
, use assertFalse
, and when there are assertTrue(x is y)
, use assertIs
. In addition, confirm()
may have more than 1 conditions so they should be broken down.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I messed up and re-ran a broken script after, causing some issues. Sent a fixup |
That should be all now, I hope… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever there is "is(X, None)", use assertIsNone
. I won't correct more.
Thanks :-) |
And backport? |
Mmh, yes backports can be done to ease future bps |
Thanks @StanFromIreland for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…H-133000) (cherry picked from commit 56c88e4) Co-authored-by: Stan Ulbrych <[email protected]>
GH-133024 is a backport of this pull request to the 3.13 branch. |
) (#133024) Co-authored-by: Stan Ulbrych <[email protected]>
Replaces all single line asserts, all the old confirms that have multiple lines will be in another pr as the diff is harder to view.
Once raised in #63882 (comment):
And also a few times in #132879
Request: @picnixz , @hugovk , @zware