gh-131531: Make Android build retry after network failures#133193
Merged
freakboy3742 merged 1 commit intopython:mainfrom May 1, 2025
Merged
gh-131531: Make Android build retry after network failures#133193freakboy3742 merged 1 commit intopython:mainfrom
freakboy3742 merged 1 commit intopython:mainfrom
Conversation
Member
Author
|
!buildbot android |
|
🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 4c83a6b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133193%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742
approved these changes
May 1, 2025
Contributor
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
I guess time will tell whether 5 retries is enough. Otherwise, looks like a solid collection of cleanups.
|
Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 1, 2025
…honGH-133193) Adds a retry strategy when downloading compilation resources for Android, plus some other cleanups. (cherry picked from commit feac343) Co-authored-by: Malcolm Smith <[email protected]>
|
GH-133236 is a backport of this pull request to the 3.13 branch. |
freakboy3742
pushed a commit
that referenced
this pull request
May 1, 2025
…-133193) (#133236) Adds a retry strategy when downloading compilation resources for Android, plus some other cleanups. (cherry picked from commit feac343) Co-authored-by: Malcolm Smith <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit was cherry-picked from #132870, because the buildbots have had a lot of intermittent download failures from GitHub URLs in the last few days.
It uses curl's
--retry-all-errorsflag, because some of the failures have returned codes that indicate a permanent failure (e.g. 403), even though it's actually temporary.Other cleanups:
shutil.unpack_archiveto remove the dependency on an externaltarcommand.