gh-137838: Fix JIT trace buffer overrun by increasing possible exit stubs #138177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be better approach than #138173, but issue is that max_length will be shorter than current, not sure that this apporach will be fine. |
| // Need space for _DEOPT | ||
| max_length--; | ||
|
|
||
| max_length-=2; |
There was a problem hiding this comment.
Needs comment on why 2:
// One for possible _DEOPT, one because _CHECK_VALIDITY itself might _DEOPT
Fidget-Spinner
approved these changes
Aug 28, 2025
|
Gentle ping @markshannon: I plan to create a separate PR to move this to the thread state after merging this PR. |
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.