gh-76007: Deprecate __version__ attribute
#138675
Open
+303
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
requested review from
vsajip,
savannahostrowski,
sethmlarson and
AA-Turner
as code owners
sethmlarson
approved these changes
Sep 8, 2025
|
Reviewed the SBOM changes. |
merwok
reviewed
Sep 9, 2025
|
|
||
| .. Add deprecations above alphabetically, not here at the end. | ||
| .. include:: ../deprecations/pending-removal-in-3.16.rst | ||
|
|
||
| .. include:: ../deprecations/pending-removal-in-3.17.rst |
There was a problem hiding this comment.
So this will show the same list twice in this page?
There was a problem hiding this comment.
Yep, that's how we're already doing it for other ones (I'm not sure if we should, but that's another discussion).
vsajip
approved these changes
Sep 9, 2025
encukou
reviewed
Sep 9, 2025
| if name == "__version__": | ||
| from warnings import _deprecated | ||
|
|
||
| _deprecated("__version__", remove=(3, 17)) |
There was a problem hiding this comment.
PEP 387 says:
It is preferred, though, to wait 5 years before removal (e.g., warn starting in Python 3.10, removal in 3.15; this happens to coincide with the current lifetime of a minor release of Python).
Suggested change
| _deprecated("__version__", remove=(3, 17)) | |
| _deprecated("__version__", remove=(3, 20)) |
Or is there a reason to rush this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--138675.org.readthedocs.build/