gh-138991: Update dataclass documentation for new eq behavior in Python 3.13 and add tests #139007
+47
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
| generated. | ||
|
|
||
| .. versionchanged:: 3.13 | ||
| The generated ``__eq__`` method now compares each field individually (e.g., ``self.a == other.a and self.b == other.b``), rather than comparing tuples of fields as in previous versions. |
There was a problem hiding this comment.
Please wrap lines to 79 characters.
Also, please don't use Latin abbreviations, see the devguide for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#138991
This PR updates the documentation for the
eqparameter in thedataclassesmodule to reflect the new field-by-field comparison behavior introduced in Python 3.13.A .. versionchanged:: 3.13notice has been added, and the previous tuple-based comparison for Python 3.12 and earlier is described for clarity.Additionally, new tests have been added to verify the updated
__eq__implementation, including field-by-field comparison, type checking, and custom field equality logic.Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !
📚 Documentation preview 📚: https://cpython-previews--139007.org.readthedocs.build/