gh-134584: Eliminate redundant refcounting from _STORE_ATTR_WITH_HINT
#142767
+69
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H_HINT Signed-off-by: Manjusaka <[email protected]>
Zheaoli
requested review from
Fidget-Spinner,
markshannon and
tomasr8
as code owners
27 tasks
Signed-off-by: Manjusaka <[email protected]>
Fidget-Spinner
approved these changes
Dec 15, 2025
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
LGTM.
PS. For other people wondering, these changes are quite manual. The hard part is writing a test for them.
Signed-off-by: Manjusaka <[email protected]>
Contributor
Author
|
Resolve conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.