Skip to content

gh-142784: Make the asyncio REPL call .close() on the loop #142785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 10 commits into from
Dec 18, 2025
Merged

gh-142784: Make the asyncio REPL call .close() on the loop #142785

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
92f629b
Employ `asyncio.Runner` in the asyncio REPL
johnslavik Dec 16, 2025
95cc73a
Add news entry
johnslavik Dec 16, 2025
ac134b1
Better wording in the news entry
johnslavik Dec 16, 2025
9cbbf21
Revert "Employ `asyncio.Runner` in the asyncio REPL"
johnslavik Dec 18, 2025
4639600
Call `.stop()` on the event loop when the asyncio REPL exits
johnslavik Dec 18, 2025
d3f670d
Add test to check asyncio REPL closes the loop
johnslavik Dec 18, 2025
8b0824a
Better test name
johnslavik Dec 18, 2025
f5031b0
Move `loop.close()` below console log in present continuous tense
johnslavik Dec 18, 2025
5e45253
Remove test
johnslavik Dec 18, 2025
c5566ab
Use a crossref to asyncio in the news entry
johnslavik Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/asyncio/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@ def interrupt(self) -> None:
from _pyrepl.main import CAN_USE_PYREPL

return_code = 0
loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
runner = asyncio.Runner()
loop = runner.get_loop()

repl_locals = {'asyncio': asyncio}
for key in {'__name__', '__package__',
Expand Down Expand Up @@ -240,4 +240,5 @@ def interrupt(self) -> None:
break

console.write('exiting asyncio REPL...\n')
runner.close()
sys.exit(return_code)
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-12-16-04-39-27.gh-issue-142784.HBGJag.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The asyncio REPL now properly closes the loop upon the end of session.
Contributed by Bartosz Sławecki.
Loading