gh-93096: Remove python -m base64 -t
#94230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
corona10
requested changes
Jul 2, 2022
corona10
reviewed
Jul 2, 2022
Lib/base64.py
Outdated
| @@ -570,8 +570,7 @@ def main(): | |||
| usage = """usage: %s [-h|-d|-e|-u|-t] [file|-] | |||
There was a problem hiding this comment.
nit: Can we update usage to use f-string?
There was a problem hiding this comment.
Done. Should I go further and convert it to argparse?
|
I have made the requested changes; please review again. |
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_base64.LegacyBase64TestCase.test_encodebytes/test_decodebytesis a more advanced version of the removed CLI argument.The removed feature brings no benefit to an end user (unlike the rest of
python -m base64).