Skip to content

Do not rebuild when it's not needed (like there's no updates). #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 20, 2023
Merged

Do not rebuild when it's not needed (like there's no updates). #171

merged 8 commits into from
Oct 20, 2023

Conversation

JulienPalard
Copy link
Member

Beware it's based on the unmerged config branch...

@JulienPalard JulienPalard mentioned this pull request Oct 15, 2023
Merged
@egeakman
Copy link
Contributor

See #169

@JulienPalard JulienPalard force-pushed the mdk-no-rerun branch 2 times, most recently from 62226cb to c6c75d2 Compare October 17, 2023 20:20
@JulienPalard
Copy link
Member Author

The state file should also remember the release-cycle.json "content"/hash/whatever, because if this file change ALL release have to be built again in order to update the version picker and the sidebar of all versions.

@JulienPalard JulienPalard mentioned this pull request Oct 19, 2023
Open
@JulienPalard JulienPalard changed the title [WIP] Do not rebuild when it's not needed (like there's no updates). Do not rebuild when it's not needed (like there's no updates). Oct 19, 2023
@JulienPalard
Copy link
Member Author

I'm running it successfully on my machine, even if it miss a few things like a full rebuild when version changes, I'd like to merge the current version to see it behave in real conditions.

It logs nicely, like:

INFO ja/3.11: Should rebuild: new translations (from 2ff0f1c8335c696c87310d38dee7e73dd8105e36 to 3ffb0b0eb9687707ffb0c2a01cb32bba7825b5d8)
INFO zh-tw/3.12: Should rebuild: Doc/ has changed (from 228b12493286a7cb959438cd5b1a018e0afb17a8 to e37d56e8ddb8a95ab71d0eaba98c5be326428061)
INFO tr/3.11: Nothing changed, no rebuild needed.
INFO pt-br/3.11: Nothing changed, no rebuild needed.

@egeakman
Copy link
Contributor

I agree, let's merge it and see how well it performs 👍

@JulienPalard JulienPalard merged commit f27dbeb into python:main Oct 20, 2023
@JulienPalard JulienPalard deleted the mdk-no-rerun branch October 20, 2023 12:12
This was referenced Oct 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulienPalard @egeakman