-
-
Notifications
You must be signed in to change notification settings - Fork 62
Show elapsed time for build and publishing #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated to wrap "Full build start." / "Full build done (%s)." around the main This allows us to easily grep the daily build logs to see how long the single full build from the cron takes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hugovk for adding this and some standard code quality tools that we use in the rest of the docs ecosystem.
Helps #169.
The logs for a single language/version look like this:
logs
The longest "start"/"done" times are:
This is the longest part of the build, taking about 90 minutes here.
(The slowest command is the actual Sphinx/latex/PDF build:
make -C /srv/docsbuild/cpython/Doc ...
)This PR adds a duration to the "done" line:
We also have a "Publishing start"/"Publishing done" pair, which can take a couple of minutes (#184) so I added it there too.
This means we can easily see how long they take in the logs, which will help us analyse build times for #169.
I added tests for the new
format_seconds
function, plus added it to the CI with linting.It uses the
match
statement, new in Python 3.10, so that's the minimum required. The docs server uses 3.10 (although 3.12 is also installed).