Skip to content

Make any callable compatible with (*args: Any, **kwargs: Any) #11203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 13, 2022
Merged

Make any callable compatible with (*args: Any, **kwargs: Any) #11203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e5250d4
Make any callable compatible with (*args: Any, **kwargs: Any)
Sep 27, 2021
eb7f369
proper type
Sep 27, 2021
3c6f959
fix up tests
Sep 27, 2021
5d7cc46
another test
Sep 27, 2021
a3abf7b
Merge branch 'master' into anycallable
ilevkivskyi Aug 12, 2022
83fe962
Fix black
ilevkivskyi Aug 12, 2022
168e064
Fix a test
ilevkivskyi Aug 12, 2022
9edc6f8
Fix a test for real
ilevkivskyi Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions mypy/subtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
# Circular import; done in the function instead.
# import mypy.solve
from mypy.nodes import (
ARG_STAR,
ARG_STAR2,
CONTRAVARIANT,
COVARIANT,
Decorator,
Expand Down Expand Up @@ -1291,6 +1293,16 @@ def are_parameters_compatible(
right_star = right.var_arg()
right_star2 = right.kw_arg()

# Treat "def _(*a: Any, **kw: Any) -> X" similarly to "Callable[..., X]"
if (
right.arg_kinds == [ARG_STAR, ARG_STAR2]
and right_star
and isinstance(get_proper_type(right_star.typ), AnyType)
and right_star2
and isinstance(get_proper_type(right_star2.typ), AnyType)
):
return True

# Match up corresponding arguments and check them for compatibility. In
# every pair (argL, argR) of corresponding arguments from L and R, argL must
# be "more general" than argR if L is to be a subtype of R.
Expand Down
10 changes: 10 additions & 0 deletions test-data/unit/check-classes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7136,6 +7136,16 @@ class B(A): # E: Final class __main__.B has abstract attributes "foo"
class C:
class C1(XX): pass # E: Name "XX" is not defined

[case testArgsKwargsInheritance]
from typing import Any

class A(object):
def f(self, *args: Any, **kwargs: Any) -> int: ...

class B(A):
def f(self, x: int) -> int: ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is very handy in some cases, #5876 has a handful of them. But, it is important to remember that this is not type-safe.

from typing import Any

class A(object):
    def f(self, *args: Any, **kwargs: Any) -> int: ...

class B(A):
    def f(self, x: int) -> int: ...

def test(arg: A):
    arg.f(x=0, kw1=1, kw2=2)

test(A())  # ok
test(B())  # mypy is ok with that, but raises TypeError in real-life

It breaks Liskov's law.

Maybe we can somehow limit the scope of this new rule? For example:

  • It is fine for decorator example from Make any callable compatible with (*args: Any, **kwargs: Any)? #5876
  • It is fine for Protocol check (when protocol defines less-or-equally broad signature): Procol.method(self, arg: int) -> is ok with Impl.method(self, *args, **kwargs)
  • It is fine for callbacks
  • Maybe something else
  • It is not fine for subclassing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think the ask is explicitly for something that is not type safe. The check when "protocol defines less-or-equally broad signature" should already work. The decorator example from #5876 is a little interesting; this PR doesn't actually change inference there.

#5876 is probably a top five most popular mypy issue, so ideally something would be done. Maybe the answer is another flag.

[builtins fixtures/dict.pyi]

[case testClassScopeImports]
class Foo:
from mod import plain_function # E: Unsupported class scoped import
Expand Down
6 changes: 3 additions & 3 deletions test-data/unit/check-functions.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,9 @@ if int():
ee_var = everywhere

if int():
ee_var = specific_1 # The difference between Callable[..., blah] and one with a *args: Any, **kwargs: Any is that the ... goes loosely both ways.
ee_var = specific_1
if int():
ee_def = specific_1 # E: Incompatible types in assignment (expression has type "Callable[[int, str], None]", variable has type "Callable[[VarArg(Any), KwArg(Any)], None]")
ee_def = specific_1

[builtins fixtures/dict.pyi]

Expand Down Expand Up @@ -1787,7 +1787,7 @@ def f2(*args, **kwargs) -> int: pass
d(f1)
e(f2)
d(f2)
e(f1) # E: Argument 1 to "e" has incompatible type "Callable[[VarArg(Any)], int]"; expected "Callable[[VarArg(Any), KwArg(Any)], int]"
e(f1)

[builtins fixtures/dict.pyi]

Expand Down
6 changes: 3 additions & 3 deletions test-data/unit/check-modules.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3160,7 +3160,7 @@ from test1 import aaaa # E: Module "test1" has no attribute "aaaa"
import b
[file a.py]
class Foo:
def frobnicate(self, *args, **kwargs): pass
def frobnicate(self, x, *args, **kwargs): pass
[file b.py]
from a import Foo
class Bar(Foo):
Expand All @@ -3178,12 +3178,12 @@ class Bar(Foo):
[out1]
tmp/b.py:3: error: Signature of "frobnicate" incompatible with supertype "Foo"
tmp/b.py:3: note: Superclass:
tmp/b.py:3: note: def frobnicate(self, *args: Any, **kwargs: Any) -> Any
tmp/b.py:3: note: def frobnicate(self, x: Any, *args: Any, **kwargs: Any) -> Any
tmp/b.py:3: note: Subclass:
tmp/b.py:3: note: def frobnicate(self) -> None
[out2]
tmp/b.py:3: error: Signature of "frobnicate" incompatible with supertype "Foo"
tmp/b.py:3: note: Superclass:
tmp/b.py:3: note: def frobnicate(self, *args: Any, **kwargs: Any) -> Any
tmp/b.py:3: note: def frobnicate(self, x: Any, *args: Any, **kwargs: Any) -> Any
tmp/b.py:3: note: Subclass:
tmp/b.py:3: note: def frobnicate(self, *args: Any) -> None