Update capi_version for mypyc tests to 3.8#18341
Merged
JukkaL merged 3 commits intopython:masterfrom Jan 27, 2025
Merged
Conversation
cdce8p
commented
Dec 25, 2024
| ], # Keyword arg names tuple (or NULL) | ||
| return_type=object_rprimitive, | ||
| c_function_name="_PyObject_Vectorcall", | ||
| c_function_name="PyObject_Vectorcall", |
Collaborator
Author
There was a problem hiding this comment.
PyObject_Vectorcall is available unconditionally from pythoncapi_compat.h. Included the underscore removal here so I wouldn't have to do another big PR just for that.
mypy/mypyc/lib-rt/pythoncapi_compat.h
Lines 602 to 610 in aa0b6f0
803473b to
19de2da
Compare
19de2da to
03c4bfc
Compare
JukkaL
pushed a commit
that referenced
this pull request
Jan 27, 2025
Followup to #18341 This PR updates the `capi_version` used for mypyc tests to `3.9` (mypy / mypyc requires `>=3.9`). For Python 3.9+ mypyc uses `PyObject_VectorcallMethod` instead of `CPyObject_CallMethodObjArgs` and select `PyObject_Vectorcall` where ever possible. Will remove the now unnecessary `use_method_vectorcall` check in a followup. https://github.com/python/mypy/blob/42e005c999d8341c0da6d7b93b10d05f2db2099c/mypyc/common.py#L114-L116
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
This PR updates the `capi_version` used for mypyc tests to `3.8` (mypy / mypyc requires `>=3.9`). Test data updates done with `--update-data`. For Python 3.8+ mypyc uses `_PyObject_Vectorcall` instead of `PyObject_CallFunctionObjArgs` and `PyObject_Call` where ever possible. Will remove the now unnecessary `use_vectorcall` check in a followup. https://github.com/python/mypy/blob/aa0b6f0288e6a511b750f7fe8f49a0e321362105/mypyc/common.py#L103-L105
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
Followup to python#18341 This PR updates the `capi_version` used for mypyc tests to `3.9` (mypy / mypyc requires `>=3.9`). For Python 3.9+ mypyc uses `PyObject_VectorcallMethod` instead of `CPyObject_CallMethodObjArgs` and select `PyObject_Vectorcall` where ever possible. Will remove the now unnecessary `use_method_vectorcall` check in a followup. https://github.com/python/mypy/blob/42e005c999d8341c0da6d7b93b10d05f2db2099c/mypyc/common.py#L114-L116
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
…orcall (python#18548) Followup to python#18341 and python#18546 We only support Python 3.9+, so `PyObject_Vectorcall` and `PyObject_VectorcallMethod` are always available. Remove backwards compatibility layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
capi_versionused for mypyc tests to3.8(mypy / mypyc requires>=3.9). Test data updates done with--update-data. For Python 3.8+ mypyc uses_PyObject_Vectorcallinstead ofPyObject_CallFunctionObjArgsandPyObject_Callwhere ever possible.Will remove the now unnecessary
use_vectorcallcheck in a followup.mypy/mypyc/common.py
Lines 103 to 105 in aa0b6f0