-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: add IndexExpr support to constant_fold_expr [1/2]
#19982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BobTheBuidler
wants to merge
49
commits into
python:master
Choose a base branch
from
BobTheBuidler:patch-12
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+206
−18
Open
Changes from 14 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
970cd4f
[mypyc] feat: add IndexOp support to `constant_fold_expr`
BobTheBuidler 51fdd2d
Update constant_fold.py
BobTheBuidler 4ad507a
Update constant_fold.py
BobTheBuidler bed37d6
Update constant_fold.py
BobTheBuidler d7f75f4
Update constant_fold.py
BobTheBuidler 558dee1
Update constant_fold.py
BobTheBuidler 3f18ed0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 692844c
Update constant_fold.py
BobTheBuidler 869616c
Update constant_fold.py
BobTheBuidler 22651fe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9bd78f3
Update constant_fold.py
BobTheBuidler 60574fc
Update constant_fold.py
BobTheBuidler daeaa50
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 785c221
Update constant_fold.py
BobTheBuidler 817ab5b
Merge branch 'master' into patch-12
BobTheBuidler 042f726
Update irbuild-constant-fold.test
BobTheBuidler fe2f670
Update irbuild-constant-fold.test
BobTheBuidler 377b31e
refactor
BobTheBuidler adae39f
Update expression.py
BobTheBuidler 35b0dfc
Update constant_fold.py
BobTheBuidler 6a25595
Update constant_fold.py
BobTheBuidler 8add115
Update constant_fold.py
BobTheBuidler 286a108
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0a14359
Update constant_fold.py
BobTheBuidler 2d768df
Update constant_fold.py
BobTheBuidler 4bcd5d6
Update constant_fold.py
BobTheBuidler a62ef3a
Update constant_fold.py
BobTheBuidler 3ff12ec
Update constant_fold.py
BobTheBuidler 45bcc66
Update irbuild-constant-fold.test
BobTheBuidler e2fa664
Update run-strings.test
BobTheBuidler 27193d8
Update irbuild-constant-fold.test
BobTheBuidler 4dc3a78
Merge branch 'master' into patch-12
BobTheBuidler 9481314
Merge branch 'master' into patch-12
BobTheBuidler 9c9743c
Merge branch 'master' into patch-12
BobTheBuidler e854bdb
Merge branch 'master' into patch-12
BobTheBuidler b2524ab
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 979ee73
add more tests
BobTheBuidler c24e67e
Update constant_fold.py
BobTheBuidler 98ed412
fix mypy errs
BobTheBuidler 8784efa
Update constant_fold.py
BobTheBuidler 857fe55
Update constant_fold.py
BobTheBuidler 0d0ae5d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 66c40bd
Update constant_fold.py
BobTheBuidler 9f71e3f
Update run-strings.test
BobTheBuidler 598c7f8
fix test
BobTheBuidler aaa4a19
Update constant_fold.py
BobTheBuidler 2cbcd95
Merge branch 'master' into patch-12
hauntsaninja ac60d3e
Merge branch 'master' into patch-12
BobTheBuidler 506a5ca
Merge branch 'master' into patch-12
BobTheBuidler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to check if
baseis a Sequence -- you can index anint, for example.