Skip to content

[mypyc] feat: try constant fold in convert_format_expr_to_str #20092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[mypyc] feat: try constant fold in convert_format_expr_to_str #20092

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7640fc
[mypyc] feat: try constant fold in `convert_format_expr_to_str`
BobTheBuidler Oct 20, 2025
d63eafc
Update format_str_tokenizer.py
BobTheBuidler Oct 20, 2025
58682c4
Update irbuild-str.test
BobTheBuidler Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions mypyc/irbuild/format_str_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
is_str_rprimitive,
)
from mypyc.irbuild.builder import IRBuilder
from mypyc.irbuild.constant_fold import constant_fold_expr
from mypyc.primitives.bytes_ops import bytes_build_op
from mypyc.primitives.int_ops import int_to_str_op
from mypyc.primitives.str_ops import str_build_op, str_op
Expand Down Expand Up @@ -143,16 +144,19 @@ def convert_format_expr_to_str(
for x, format_op in zip(exprs, format_ops):
node_type = builder.node_type(x)
if format_op == FormatOp.STR:
if is_str_rprimitive(node_type) or isinstance(
x, StrExpr
): # NOTE: why does mypyc think our fake StrExprs are not str rprimitives?
if is_str_rprimitive(node_type) or isinstance(x, StrExpr):
# NOTE: why does mypyc think our fake StrExprs are not str rprimitives?
var_str = builder.accept(x)
elif (folded := constant_fold_expr(builder, x)) is not None:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foldable non-string values can be easily converted to str

var_str = builder.accept(StrExpr(str(folded)))
elif is_int_rprimitive(node_type) or is_short_int_rprimitive(node_type):
var_str = builder.primitive_op(int_to_str_op, [builder.accept(x)], line)
else:
var_str = builder.primitive_op(str_op, [builder.accept(x)], line)
elif format_op == FormatOp.INT:
if is_int_rprimitive(node_type) or is_short_int_rprimitive(node_type):
if isinstance(folded := constant_fold_expr(builder, x), int):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the expr can fold as an int we can convert it to str at build time

var_str = builder.accept(StrExpr(str(folded)))
elif is_int_rprimitive(node_type) or is_short_int_rprimitive(node_type):
var_str = builder.primitive_op(int_to_str_op, [builder.accept(x)], line)
else:
return None
Expand Down