Use Pybind11 3.0.0+ #20095
Open
Use Pybind11 3.0.0+ #20095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <[email protected]>
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
A5rocks
approved these changes
Oct 22, 2025
test-data/pybind11_fixtures/expected_stubs_no_docs/pybind11_fixtures/__init__.pyi
Show resolved
Hide resolved
test-data/pybind11_fixtures/expected_stubs_with_docs/pybind11_fixtures/demo.pyi
Show resolved
Hide resolved
|
Ok will split the two comments into separate issues. Anything else you want for this pull request? |
|
Nope, looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pybind11 had a new major version bump to 3.0.0. Also fix bug in workflow to run with the new folder name.
Doesn't fix but related.
#16306