Update JSON export tool to support binary meta cache files #20096
Conversation
| @@ -1,4 +1,4 @@ | |||
| """Tool to convert mypy cache file to a JSON format (print to stdout). | |||
| """Tool to convert binary mypy cache files (.ff) to JSON (.ff.json). | |||
There was a problem hiding this comment.
| """Tool to convert binary mypy cache files (.ff) to JSON (.ff.json). | |
| """Tool to convert binary mypy cache files (.ff) to JSON (.json). |
There was a problem hiding this comment.
Oh, I see you actually don't strip the original extension. I think it is better to do this, i.e. use .data.json or .meta.json for output files.
There was a problem hiding this comment.
I did it this way so that there is no confusion between the "real" JSON cache files and the ones produced by the converter -- there's no guarantee that mypy will be able to read the output, since we don't guarantee that it stays in sync with the actual JSON format.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Interesting, file hashes appear to be different on Windows. Maybe it's due to CRLF conversion. I will investigate -- maybe the test found a minor bug or at least inconsistency. |
2 participants
The test case needs to filter out quite a few things that are unpredictable.