Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 685: Comparison of extra names for optional distribution dependencies #2391

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

brettcannon
Copy link
Member

No description provided.

@brettcannon brettcannon requested a review from a team as a code owner March 9, 2022 01:32
@brettcannon
Copy link
Member Author

I will update the Discussions-To link to a proper one on discuss.python.org once this is passing CI.

@brettcannon brettcannon merged commit c4bbfce into python:main Mar 9, 2022
@brettcannon brettcannon deleted the pep-0685 branch March 9, 2022 01:40
e.g. ``___`` stays the same.

For pip, its
"extra normalisaton behaviour is quite convoluted and eratic",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"extra normalisaton behaviour is quite convoluted and eratic",
"extra normalisaton behaviour is quite convoluted and erratic",

Specification
=============

[Describe the syntax and semantics of any new language feature.]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

This applies to the ``Provides-Extra`` field and the ``Provides-Dist``
field both when specifying extras for a distribution as well as the
``extra`` marker.
This will also help enforce the curren requirement from the core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This will also help enforce the curren requirement from the core
This will also help enforce the current requirement from the core

tool ends up installing distributions that somehow weaken the security
of the system.
This is only hypothetical and if it were to occur it would probably be
more of a security concern for the distributions involved more than
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
more of a security concern for the distributions involved more than
more of a security concern for the distributions involved than

The whole sentence isn't easy to follow though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants