Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint: Update outdated package dependencies & reformat files #3291

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Lint: Update outdated package dependencies & reformat files #3291

merged 2 commits into from
Aug 16, 2023

Conversation

shailshouryya
Copy link
Contributor

@shailshouryya shailshouryya commented Aug 16, 2023 •
edited by github-actions bot
Loading

See message in commit c58adfa for details.

📚 Documentation preview 📚: https://pep-previews--3291.org.readthedocs.build/

@shailshouryya
Copy link
Contributor Author

I read through https://github.com/python/peps/blob/main/CONTRIBUTING.rst#commit-messages-and-pr-titles, and I was unsure if I should prefix the title with Infra: or with Lint:. This change is associated with a Lint issue (#3028), but the change itself is updating a build dependency, so I think Infra is more relevant. Feel free to update as needed!

@hugovk hugovk changed the title Infra: Update sphinx-lint package dependency version number → 0.6.8 Lint: Update sphinx-lint package dependency version number → 0.6.8 Aug 16, 2023
@hugovk
Copy link
Member

hugovk commented Aug 16, 2023

Whilst we're here, please could you update the others?

Instructions: #3028 (comment)

@hugovk hugovk added the lint Linter-related work and linting fixes on PEPs label Aug 16, 2023
@shailshouryya
Update other outdated dependencies
2c0889a 
Run the following:

```
python -m pip install pre-commit
pre-commit autoupdate
pre-commit run --all-files
```
@shailshouryya shailshouryya requested review from AA-Turner and a team as code owners August 16, 2023 04:51
@shailshouryya
Copy link
Contributor Author

Thanks for catching that, looks like pre-commit autoupdate didn't run properly the first time and I forgot to rerun that step.

Let me know if I need to update anything else!

@shailshouryya shailshouryya changed the title Lint: Update sphinx-lint package dependency version number → 0.6.8 Lint: Update outdated package dependencies & reformat files Aug 16, 2023
@shailshouryya
Copy link
Contributor Author

shailshouryya commented Aug 16, 2023 •
edited
Loading

I also updated the title again, since the pre-commit autoupdate found more packages to update and my initial title is now inaccurate - feel free to update that as well!

hugovk
hugovk approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk merged commit 0ebf5a4 into python:main Aug 16, 2023
@hugovk hugovk mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach CAM-Gerlach is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
lint Linter-related work and linting fixes on PEPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shailshouryya @hugovk