-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 812: Imaginary type and IEC 60559-compatible complex arithmetic #4681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Based on feedback from the latest discussion thread, I hope @serhiy-storchaka might sponsor this. CC @serhiy-storchaka (Alternative formatting with mathjax)N.B. I did local builds with the default sphinx config and it seems, that "math" directives are rendered odd with the "maths_to_html". In particular, equation numbering is lost (though, references to equations are kept). Any way to fixing this without replacing "math" with something else? CC @AA-Turner |
|
Please review PEP 1. The general order of things:
Therefore please don't write and submit a PEP with just a hope someone will sponsor. This should be arranged beforehand. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yes, you may use 812. Thanks! |
| .. [5] `Ada 2022 Reference Manual | ||
| <http://ada-auth.org/standards/22rm/RM-Final.pdf>`_, Annex G. | ||
|
|
||
| .. [6] `GNU Scientific Library, Release 2.7 | ||
| <https://www.gnu.org/software/gsl/doc/latex/gsl-ref.pdf>`_, §5.5. | ||
|
|
||
| .. [7] `The GNU Multiple Precision Complex Library, Edition 1.3.1 | ||
| <https://www.multiprecision.org/downloads/mpc-1.3.1.pdf>`_, §5.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer to avoid using footnotes when there's not additional info in the footnote, so we can save our readers a click to get to the important info. I think 5-7 would be better as inline links in the prose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think they are principally different from the rest. Important info already included in the text. Footnotes are for additional stuff and/or references.
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly grammar nits.
Co-authored-by: Hugo van Kemenade <[email protected]>
|
@serhiy-storchaka, I hope now this ready for your review. Perhaps, the major remaining question is: should we try to introduce the imaginary builtin from beginning? Current version don't do so (it's in Open Issues), but maybe this should be reverted? If we introduce a new builtin - this PEP can discuss parsing of strings, which it will accept. |
Co-authored-by: Hugo van Kemenade <[email protected]>

Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4681.org.readthedocs.build/
https://pep-previews--4681.org.readthedocs.build/pep-0812/