Skip to content

Fix #2626: Fix Multi Year String Render For Single Day Events #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alvindera97
Copy link
Contributor

Summary

Description

  • Ensure single day events only render a single year string
  • Include guarantees on condition for rendering end date year string for multi-day events.

Closes

Screenshots

Before

image

After

image

Add test that checks single day event renders year string exactly once since event is guaranteed to commence and conclude within the same day and hence the same year.
Add test that checks for proper year string rendering on multi-day events.
Fix incorrect rendering logic at template ensuring:
• Single day events only render one year string.
• Multi-day events only render end-date-year string only if it's valid.
@GIgako19929
Copy link

This pull request enhances the event rendering logic by refining how event dates are displayed in the UI and adding comprehensive test coverage for these changes. The updates ensure that date-related information is only displayed when relevant, improving clarity for users.

Test Enhancements:

Template Updates:

  • Simplified the time_tag.html template to conditionally render the start and end year spans only when necessary:
    • Removed redundant start span logic for events scheduled to end in the current year.
    • Adjusted the placement of the end span to ensure it is displayed only when valid_dt_end is true, maintaining consistency with the new test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants