Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paramiko: Improve various bytes-related types #10109

Merged
merged 4 commits into from
May 3, 2023
Merged

paramiko: Improve various bytes-related types #10109

merged 4 commits into from
May 3, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 29, 2023 •
edited
Loading

Part of #9006

Fixes #5736

@JelleZijlstra JelleZijlstra mentioned this pull request Apr 29, 2023
Closed
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau
srittau approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not confirm the types against runtime types, but they all look plausible.

@srittau srittau merged commit 8e24885 into python:main May 3, 2023
@JelleZijlstra JelleZijlstra deleted the paramiko branch May 3, 2023 13:55
@JelleZijlstra JelleZijlstra restored the paramiko branch September 10, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

paramiko stubs seem incorrect for python3
2 participants
@JelleZijlstra @srittau