Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete openpyxl title type annotations #10563

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Aug 11, 2023

Extracted and improved from #9511

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

graphql-core (https://github.com/graphql-python/graphql-core): typechecking got 1.26x slower (44.4s -> 55.9s)
(Performance measurements are based on a single noisy sample)

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not compare to implementation, but looks plausible to me.

@srittau srittau merged commit af36a15 into python:main Aug 15, 2023
@Avasam Avasam deleted the openpyxl-title branch February 29, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants