Skip to content

Fix: pyopenxl: CellRange: title should not be required #10688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix: pyopenxl: CellRange: title should not be required #10688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions stubs/openpyxl/openpyxl/worksheet/cell_range.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ class CellRange(Serialisable):
min_row: MinMax[int, Literal[False]]
max_col: MinMax[int, Literal[False]]
max_row: MinMax[int, Literal[False]]
# Could be None if the caller forgot to set title and range_string doesn't contain "!"
# but that's not intended and will lead to errors (ie: can't be None in __str__)
title: str
title: str | None

@overload
def __init__(
Expand All @@ -35,7 +33,7 @@ class CellRange(Serialisable):
min_row: _ConvertibleToInt,
max_col: _ConvertibleToInt,
max_row: _ConvertibleToInt,
title: str,
title: str | None = None,
) -> None: ...
@property
def bounds(self): ...
Expand Down