Improve typing of sysconfig.get_config_var(s)
#11454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Feb 19, 2024
This comment has been minimized.
This comment has been minimized.
stdlib/sysconfig.pyi
Outdated
| @@ -15,11 +16,15 @@ __all__ = [ | |||
| "parse_config_h", | |||
| ] | |||
|
|
|||
| @overload | |||
| @deprecated("SO is deprecated, use EXT_SUFFIX") | |||
There was a problem hiding this comment.
sysconfig.py doesn't mention this, can you link to where it's indicated that "SO" is deprecated?
There was a problem hiding this comment.
Looks like support has been removed in Python 3.11
https://github.com/python/cpython/pull/91671/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70L670-L673
I'll add this to the deprecation comment now that I found the removal date.
There was a problem hiding this comment.
Thanks, I only looked at the main branch.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 tasks
JelleZijlstra
approved these changes
Feb 22, 2024
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils.sysconfig.get_config_varsupdate is relevant for setuptools (pypa/setuptools#4228). I've updatedget_config_varand all duplicates of these method as well.