Clean up argparse hacks #13450
Clean up argparse hacks #13450
Conversation
| # more precisely, Literal["store", "store_const", "store_true", | ||
| # "store_false", "append", "append_const", "count", "help", "version", | ||
| # "extend"], but using this would make it hard to annotate callers | ||
| # that don't use a literal argument | ||
| _ActionStr: TypeAlias = str |
There was a problem hiding this comment.
See comment in the code below. This can never be literal because users can register actions
| # more precisely, Literal["?", "*", "+", "...", "A...", | ||
| # "==SUPPRESS=="], but using this would make it hard to annotate | ||
| # callers that don't use a literal argument | ||
| _NArgsStr: TypeAlias = str |
There was a problem hiding this comment.
Moved the comment below, there is no need for a type alias
| _SUPPRESS_T = NewType("_SUPPRESS_T", str) | ||
| SUPPRESS: _SUPPRESS_T | str # not using Literal because argparse sometimes compares SUPPRESS with is | ||
| # the | str is there so that foo = argparse.SUPPRESS; foo = "test" checks out in mypy | ||
| SUPPRESS: Final = "==SUPPRESS==" |
There was a problem hiding this comment.
This comment is obsolete, both mypy and pyright are happy with this idiom
import argparse
reveal_type(argparse.SUPPRESS) # reveal "Literal['==SUPPRESS==']"
help = argparse.SUPPRESS
help = "help"Also pyright recently learned how to correctly narrow with identity checking a literal (using if help is argparse.SUPPRESS), mypy already worked fine
There was a problem hiding this comment.
FYI This particular change might still have been required. Removing it broke the mypyc compiled test runs. See python/mypy#18580.
I partially reverted this commit in python/mypy#18683 -> python/mypy@756e61a to fix the mypy typeshed sync.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Source commit: python/typeshed@cc8ca93 Partially revert python/typeshed#13450 to fix mypyc runs.
Source commit: python/typeshed@cc8ca93 Partially revert python/typeshed#13450 to fix mypyc runs.
Some of these hacks are obsolete, some of them are due to wrong assumptions.