Fix _Pickle.reducer_override annotation#13545
Open
srittau wants to merge 6 commits intopython:mainfrom
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Comment on lines
+218
to
+221
| # The following method is not defined on _Pickler, but can be defined on | ||
| # sub-classes. Should return `NotImplemented` if pickling the supplied | ||
| # object is not supported and returns the same types as `__reduce__()`. | ||
| def reducer_override(self, obj: object, /) -> _ReducedType: ... |
Collaborator
There was a problem hiding this comment.
Should this be done for _pickler.Pickler (aka the public pickle.Pickler) as well?
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Stubtest errors are unrelated. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #13446