Drop flake8-noqa and remove workarounds to work with Ruff #13571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
dropping-flake8-noqa
branch
from
31ff0f0 to
9201687
Compare
This comment has been minimized.
This comment has been minimized.
Avasam
commented
Mar 2, 2025
| @@ -66,8 +66,7 @@ select = [ | |||
| "FURB177", # Prefer `Path.cwd()` over `Path().resolve()` for current-directory lookups | |||
| "FURB187", # Use of assignment of `reversed` on list `{name}` | |||
| # PYI: only enable rules that have autofixes and that we always want to fix (even manually), | |||
There was a problem hiding this comment.
In a separate PR (or this one if you prefer), this could be changed to
Suggested change
| # PYI: only enable rules that have autofixes and that we always want to fix (even manually), | |
| # PYI: only enable rules for which we never noqa their flake8-pyi plugin equivalent, |
Even better imo is to instead select all and disable the few codes where this happens.
Avasam
changed the title
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13296 See that issue for explanation.
If the package is ever updated to include plinss/flake8-noqa#30 we could partially revert this PR.
As a follow-up, I can include more flake8-pyi (PYI) codes and simplify its config in
pyproject.toml. By excluding some codes instead of including most of them.