[stubsabot] Support "Removal" PRs #14401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donBarbos
changed the title
donBarbos
changed the title
srittau
requested changes
Jul 16, 2025
Comment on lines
+511
to
+515
| try: | ||
| with metadata_path(distribution).open("rb") as file: | ||
| data = tomlkit.load(file) | ||
| except FileNotFoundError: | ||
| raise NoSuchStubError(f"Typeshed has no stubs for {distribution!r}!") from None |
There was a problem hiding this comment.
Note for later: We should probably extract that into a separate function in ts_utils.metadata. This is used several times in a few files. But in a later PR, not here.
| if not comment: | ||
| return False | ||
|
|
||
| release_date_string = comment.removeprefix("# Released on ") |
There was a problem hiding this comment.
Note: This is probably also something that we should put into metadata (possibly as a structured obsolete field with since_version and since_date fields), but again in a later PR.
srittau
reviewed
Jul 16, 2025
srittau
approved these changes
Jul 16, 2025
|
Thank you! |
donBarbos
added a commit
to donBarbos/typeshed
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discuss: #14402