regex: accept buffers #7680
Merged
regex: accept buffers #7680
+406
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to python#7679
srittau
approved these changes
Apr 24, 2022
This comment has been minimized.
This comment has been minimized.
|
@rchen152, could you possibly take a look at the pytype crash when you have a moment? (Not urgent!) :) |
Looking now! |
|
I have a fix for the pytype issue out for review. Should be able to release it tomorrow or Wednesday. |
Brilliant, thank you! |
rchen152
added a commit
to google/pytype
that referenced
this pull request
May 10, 2022
For python/typeshed#7680. PiperOrigin-RevId: 447596238
|
pytype-2022.5.10 contains the fix. |
Merged
|
Diff from mypy_primer, showing the effect of this PR on open source code: paroxython (https://github.com/laowantong/paroxython)
- paroxython/parse_program.py:240: error: Incompatible types in assignment (expression has type "Callable[[str, Optional[int], Optional[int], bool, Optional[bool], Optional[float]], Scanner[str]]", target has type "Pattern[Any]")
+ paroxython/parse_program.py:240: error: Incompatible types in assignment (expression has type "Callable[[str, int, int, bool, Optional[bool], Optional[float]], Scanner[str]]", target has type "Pattern[Any]")
|
|
Thanks @rchen152! CI is green now and Sebastian approved a while ago, so I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #7679