Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate known magic method return types #9131

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Annotate known magic method return types #9131

merged 4 commits into from
Nov 8, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 8, 2022 •
edited
Loading

I was pretty careful to include only 100% ones.

srittau
srittau approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some cases, where the dunder method does something strange in the implementation, but as long as primer passes, I think this situation is better than the alternative and potential problems can be fixed when they come up.

@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@sobolevn
Copy link
Member Author

sobolevn commented Nov 8, 2022

Looks like I need to fix metaclasses of many projects.

@srittau can you please trigger daily task? I don't have permissions in this repo to do that.

@AlexWaygood
Copy link
Member

AlexWaygood commented Nov 8, 2022 •
edited
Loading

@sobolevn the daily run already failed last night with the metaclass-related stubtest changes: #9127

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 62a6c3d into python:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @AlexWaygood @srittau