Skip to content

Mark SQLAlchemy stubs with ignore_missing_stub = false #9653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Apr 27, 2023

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Feb 1, 2023

Follow-up to #9596 (keeping as draft until that one is merged)
Mostly used stubgen for the missing types. Except for stubs/SQLAlchemy/sqlalchemy/sql/annotation.pyi which had to be done manually.

Changes to imports:

There's still a pytype issue I'm not certain about.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Avasam Avasam marked this pull request as ready for review April 15, 2023 00:51
@github-actions

This comment has been minimized.

@Avasam
Copy link
Collaborator Author

Avasam commented Apr 15, 2023

I don't understand what this Pytype error is trying to tell me. Other than that, this PR is ready to be looked at.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra merged commit 6cb8bc0 into python:main Apr 27, 2023
@Avasam Avasam deleted the sqlalchemy-stubgen branch April 27, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants